search

swansonj2019 / PersonalMovieDatabase

A Personal Movie Database Application
0 stars 0 forks source link

Kevin's Feedback - Week 6 #4

Open kkelm opened 4 years ago

kkelm commented 4 years ago

Design/Code Review 1

Project:

Personal Movie Database

Developer:

Joel Swanson

Reviewer:

Kevin Kelm

Item Considerations Comments/Suggestions
Problem Statement 1. Accurately describes project purpose
2. Is professional and free of typos, slang, etc.
3. Fully explains the problem and the solution
4. Is understandable by the average person		 The problem statement is short and to the point, also describes the project in simple terms and doesn't get too technical.
Design Documentation 1. Navigation/flow through the application is logical and easy to use.
2. The order in which values are displayed are logical and easy to understand/use
3. The order in which the form fields entered are logical and easy to understand/use
4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens		 The wire frames have a good start but probably should have a couple more to show the other screens, and the user stories look good.
Data model/Database 1. Everything on the screens and problem statement/flow is represented in the model
2. There is at least one 1-to-many relationship.
3. The model represents good database design		 By looking at the code it appears the database is coming along, could use an ERD to look at.
Code 1. Proper Maven project structure is used
2. a .gitignore file for IntelliJ Java projects has been implemented
3. There is not any redundant or copy/paste code in the JSPs or classes
4. Classes are appropriately-sized (no monster classes)
Property files are used appropriately: no hard-coded values
5. Logging statements are used rather than System.out.println and printStackTrace.
6. There are appropriate unit tests/code coverages.		 The tests and main code is coming along well, and appears to keep up with what we've learned in class. The JavaDoc could be a little descriptive.
pawaitemadisoncollege commented 4 years ago

@kkelm How about logging? Are there any System.out.printlns?

kkelm commented 4 years ago

I didn't see any System.out's but I only see a couple logs called in the files under the persistence directory. Also, when it comes to logging I'd change logger.error(e) to logger.error(e.printStackTrace()) because e is the whole object.