Instructor Feedback - Week 15

[pawaitemadisoncollege]

First, I can't wait to see this in action during your presentation on Tuesday!

Just a few things as you put the final touches on your project:

• [ ] It would be nice to provide links to these: on your readme.md: tmdb API, UweTrottmann tmdb Java Api Wrapper, Retrofit2
• [ ] Project plan and time log haven't been touched in quite sometime - at least update the plan with what has been completed, and log your time for this last push.
• [ ] Echoing Yia's comment - use the GenericDao to eliminate that duplication in the days.
• [ ] entity classes - it might be nice to split into two packages: entities that you wrote and generated entities specific to a service you are calling. The naming convention I like to use is that the package name for the generated classes is the reverse domain name of the service. This way, the com.personalmoviedb.entity package contains only the classes you wrote.
• [ ] Rather than hard-coding the url and key, here: https://github.com/swansonj2019/PersonalMovieDatabase/blob/e17785b229168d6458b1d94b6b62a37f74036a19/src/main/java/com/personalmoviedb/persistence/MovieSearchDao.java#L29 use properties.
• [ ] Are there unit tests for each hibernate-backed entity? I think Role is missing a unit test?
• [ ] Class names should be uppercase - userDaoTest needs capitilization, for example
• [ ] pom.xml has a few version numbers "hard-coded" (I'm guilty of this when I'm getting things working too) - move those into the properties section for easy updates and consistency. Examples; https://github.com/swansonj2019/PersonalMovieDatabase/blob/e17785b229168d6458b1d94b6b62a37f74036a19/src/main/java/com/personalmoviedb/persistence/MovieSearchDao.java#L29 and https://github.com/swansonj2019/PersonalMovieDatabase/blob/e17785b229168d6458b1d94b6b62a37f74036a19/pom.xml#L139
• [ ] Is everything locked down in the web.xml that needs to be? Both the jsp and the backing servlets?
• [ ] Consider adding custom error pages for common errors like 404 and 500.