swansonk14 / typed-argument-parser

Typed argument parser for Python
MIT License
494 stars 40 forks source link

Fix #134: compare Pydantic version string correctly #136

Closed kddubey closed 4 months ago

kddubey commented 4 months ago

Fix #134.

Adds a new dependency: packaging. It has no dependencies and works w/ Python 3.8+.

See docs for packaging.version.Version

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.01%. Comparing base (7398f29) to head (fe1166d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #136 +/- ## ======================================= Coverage 94.00% 94.01% ======================================= Files 5 5 Lines 684 685 +1 ======================================= + Hits 643 644 +1 Misses 41 41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

martinjm97 commented 4 months ago

Thank you for the fix!