search

swansonk14 / typed-argument-parser

Typed argument parser for Python
MIT License
494 stars 40 forks source link

Warning during installation when `wheel` isn't installed #141

Closed kddubey closed 2 months ago

kddubey commented 2 months ago

I've been installing this package in a linux instance where I had to manually install python and pip. Looks like wheel doesn't get installed, so I get this inconsequential warning:

  DEPRECATION: typed-argument-parser is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
  Running setup.py install for typed-argument-parser ... done

Are you open to replacing setup.py with pyproject.toml? The latter has some advantages. If so, I'll have a PR ready soon :-)

martinjm97 commented 2 months ago

Yes, after reading PEP 621 and some of these answers, I'm convinced that everything that can be statically defined in a pyproject.toml should be there.

Thank you for your expertise!