swapagarwal / JARVIS-on-Messenger

:speech_balloon: A community-driven python bot that aims to be as simple as possible to serve humans with their everyday tasks
https://m.me/J.A.R.V.I.S.on.Messenger
MIT License
1.35k stars 988 forks source link

Anime: Use a new source #157

Closed swapagarwal closed 7 years ago

swapagarwal commented 7 years ago

anime module is down!!

Hummingbird is dead (https://medium.com/heykitsu/hummingbird-is-dead-long-live-kitsu-bda6ccfbbcce) See if Kitsu can be used? If not, find a new source.

conormag94 commented 7 years ago

Hi @swapagarwal I found another API called Anilist http://anilist-api.readthedocs.io/en/latest/index.html

It seems like a well documented alternative API you could possibly use?

swapagarwal commented 7 years ago

Hey @conormag94, have you played around with the API? We need to identify the right API methods to call in our module.

conormag94 commented 7 years ago

Hey @swapagarwal I haven't played around with it myself I just noticed it on a reddit post the other day and thought it could be useful.

I don't have the time at the moment to take a look at this but I could come back in 2-3 weeks and have a look at it if no one else has picked it up by then.

conormag94 commented 7 years ago

Hi @swapagarwal so I've had another look at Kitsu and I think it can be used. Its very new though so there is barely any documentation. I also don't think there is a way to register an application for authentication with Kitsu yet so they provide a public key to use.

Since the anime module just searches the old API, I think this Kitsu call can be used to replace it: http://docs.kitsu17.apiary.io/#introduction/json-api/filtering-and-search

I can have a look at replacing the old anime module call to this new API if you like? Then hopefully the api and its documentation will be updated soon.

conormag94 commented 7 years ago

Submitted a pull request to fix this #166.

swapagarwal commented 7 years ago

Hey @conormag94, great work! Thanks to you, the anime module is back up and running. 🎉 Kudos for diving into Kitsu w/o proper documentation. 😄

conormag94 commented 7 years ago

No problem @swapagarwal glad I could help 😄