search

swapagarwal / JARVIS-on-Messenger

:speech_balloon: A community-driven python bot that aims to be as simple as possible to serve humans with their everyday tasks
https://m.me/J.A.R.V.I.S.on.Messenger
MIT License
1.35k stars 988 forks source link

Units Converter Program #226

Open abrahamalbert18 opened 7 years ago

abrahamalbert18 commented 7 years ago

@swapagarwal I've written a units converter program and uploaded it and requested a pull in order to merge with Jarvis, however, my program is failing all the tests according to the stickler bot. I don't understand the reason properly. I've modified the code based on the first 36 errors shown by the stickler bot. I want you to look at the code and help me improve my code. I'd love to learn it. In this program I didn't use any api to get the conversion units. I've tested most of the cases and let me know if any bugs are to be debugged. #225 pull request Thank you, Abraham Albert

swapagarwal commented 7 years ago

Hey @abrahamalbert18 , I have disabled the Stickler Bot temporarily. Can you create a new pull request? Sorry for the trouble. 😅

abrahamalbert18 commented 7 years ago

I've updated the code and uploaded it. This code works in regular Python interpreter as it takes the input using "raw_input()". However I've a doubt in taking the input in Jarvis Module. This code works offline too. It doesn't need any APIs. Please do test it and let me know the feedback. pull request #240 @swapagarwal Thank you, Abraham Albert.

Sent from my iPhone

On 15-Jul-2017, at 12:16 AM, Swapnil Agarwal notifications@github.com wrote:

Hey @abrahamalbert18 , I have disabled the Stickler Bot temporarily. Can you create a new pull request? Sorry for the trouble. 😅

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.