search

swapagarwal / JARVIS-on-Messenger

:speech_balloon: A community-driven python bot that aims to be as simple as possible to serve humans with their everyday tasks
https://m.me/J.A.R.V.I.S.on.Messenger
MIT License
1.34k stars 989 forks source link

Time: MapQuest -> Google Maps #338

Open swapagarwal opened 6 years ago

swapagarwal commented 6 years ago

Move from MapQuest API in time module to Google Maps API. Reference PR: https://github.com/swapagarwal/JARVIS-on-Messenger/pull/319 MapQuest API will be removed as a dependency as a result.

isbee commented 6 years ago

doesn't need timeZoneDB -> Google Maps Time Zone ?

I think you want to move from bunch of APIs to Google API. but yeah, Google Map has limit on quries(75000 / month) whereas timeZoneDB has no limit.

i'll try that if you want and ofc i'll solve this issue too.

mbulhakov commented 6 years ago

Hi!

I've made a pull request regarding this issue -- #402

akshat00 commented 5 years ago

is the issue still open

Ftrain27 commented 1 year ago

I see that @mbulhakov made a pull request that was reviewed and approved by @swapagarwal, but it hasn't been merged yet. Considering that it was back in 2018, I'm guessing that it was forgotten about. @swapagarwal , can you close this issue please?