swapagarwal / JARVIS-on-Messenger

:speech_balloon: A community-driven python bot that aims to be as simple as possible to serve humans with their everyday tasks
https://m.me/J.A.R.V.I.S.on.Messenger
MIT License
1.34k stars 990 forks source link

Replace 'songs by singer' with 'singer songs' in help.py #368

Open Mohit17067 opened 6 years ago

Mohit17067 commented 6 years ago

When we type help, Jarvis shows that it can proceed with 'songs by \<singer>' ( songs by linkin park ). But instead, it should show '\<singer> songs' ( linkin park songs ) because I think music.py is implemented like this. Changing help.py may do the work. Shall I proceed?

skakim commented 6 years ago

I agree, "songs by \<singer>" doesn't work at all. Moreover, for me, "\<singer> songs" don't work for all bands. The following worked:

The following didn't work (and I didn't receive any response) (maybe newer bands/singers?):

In some cases (rarely), I receive a "I'm sorry; I'm not sure I understand what you're trying to say." answer:

Mohit17067 commented 6 years ago

That must be because the API does not have those singers on their list.