search

swapagarwal / JARVIS-on-Messenger

:speech_balloon: A community-driven python bot that aims to be as simple as possible to serve humans with their everyday tasks
https://m.me/J.A.R.V.I.S.on.Messenger
MIT License
1.35k stars 988 forks source link

Add crypto-currency conversion rates #379

Open spherinder opened 6 years ago

spherinder commented 6 years ago

Feature description:

It would be nice to implement support for getting conversion rates of crypto-currencies using Jarvis :) Currently there's only about 30 currencies supported. Do you think it's a good idea?

Any ideas on how to implement it?

Cryptonator has an API that can convert most fiat and crypto-currencies. If the current API doesn't support the given currency one could try to get the rates from Cryptonator instead.

However, on their webpage I couldn't find anything about license, and I'm new to how open source and licensing works. But it should be okay to use the API, right?

spherinder commented 6 years ago

I found another API called CryptoCompare that has all the currencies supported by the current API. So as a result one could instead just use the CryptoCompare API altogether.

They use a CC BY-NC 3.0 license though, and I don't know if the non-commercial part is a problem. I mean, messenger has ads, so would that indirectly violate the license?

parth21999 commented 4 years ago

Can I try to implement this?