search

swapagarwal / JARVIS-on-Messenger

:speech_balloon: A community-driven python bot that aims to be as simple as possible to serve humans with their everyday tasks
https://m.me/J.A.R.V.I.S.on.Messenger
MIT License
1.35k stars 990 forks source link

Add a curated list of jokes #4

Closed swapagarwal closed 8 years ago

swapagarwal commented 8 years ago

The API call in the joke module can be prevented by adding a curated list of jokes in the source file itself. Pros:

Con:

havanagrawal commented 8 years ago

Hi, I'd like to contribute to this repo.. Please let me know if I can contribute :) As a small suggestion, perhaps the joke module could have genres, such as "knock knock", "walk into a bar", "meta", "puns", etc. The user would interact by saying "tell me a knock knock joke". If no genre is mentioned, we just pick out a random one.

swapagarwal commented 8 years ago

You are welcome to contribute! Only with the help from the community can this become something big. I like the idea of having genres; I didn't implement it as I couldn't find relevant APIs. Would you be interested to take this issue and make a list of category-wise good jokes?

ghost commented 8 years ago

Hi what should be the deciding factor if a joke should be delivered by the API call or from the pre-compiled list within JARVIS?

swapagarwal commented 8 years ago

If we can hand-pick a minimum number (say 10-15) of funny jokes, then we'd remove the API call.

ghost commented 8 years ago

But don't you think it would be just repeatedly showing these 10-15 only? I think we should make use of both of them.

ghost commented 8 years ago

Also I propose we use a jokes.txt file for this list.

swapagarwal commented 8 years ago

Those 10-15 can be expanded with time. The problem with using an API is that sometimes, their jokes can be offensive to someone, so that's why we want hand-picked jokes!

ghost commented 8 years ago

Understood. I'll submit some 10-15 for starters. We can expand later :)

ghost commented 8 years ago

ss_joke So this is how it's coming up! If it's OK...I'll send a pull request. @swapagarwal

ghost commented 8 years ago

I put a \t\t\t between the joke as a syntax for handling Q&A model jokes.

swapagarwal commented 8 years ago

@shanmukhateja You can send a PR and then we can take the discussion over there. :smile:

ghost commented 8 years ago

Now that this is resolved, shouldn't we close this issue @swapagarwal ?

swapagarwal commented 8 years ago

I'd like to keep this open for newbies to get started with (by adding some more jokes). :smile:

ghost commented 8 years ago

well then they can open a new one right? Like referencing the same issue multiple times for different commits by different ppl isn't much convincing don't you think?

ghost commented 8 years ago

They can just open a new issue later ;)

swapagarwal commented 8 years ago

Yepp, they can open a new one but keeping this open would encourage new people to start contributing!

swapagarwal commented 8 years ago

Continued in #54