swapagarwal / JARVIS-on-Messenger

:speech_balloon: A community-driven python bot that aims to be as simple as possible to serve humans with their everyday tasks
https://m.me/J.A.R.V.I.S.on.Messenger
MIT License
1.34k stars 992 forks source link

Music Lyrics API : Genius #95

Closed VarunWachaspati closed 7 years ago

VarunWachaspati commented 8 years ago

Hey

I think the Genius API would be great for serving lyrics. https://docs.genius.com/

Best thing about Genius is it's annotations which actually specify the meaning and context of particular lines in a song. Great value add-on for JARVIS

What are your thoughts on this?

swapagarwal commented 7 years ago

@VarunWachaspati Sorry, I missed this somehow! 👍 for the annotations; would you like to implement this? Either Genius or MusixMatch works fine by me. 😄

seongju commented 7 years ago

I did a little research and it seems that without paying Musixmatch does not give a 'Full Lyrics Display' also Genius does not give the lyrics either.

ShaishavGandhi commented 7 years ago

There's http://api.chartlyrics.com/ that provides lyrics for non-commercial use. I don't know if Jarvis would qualify for non-commercial use. Scroll down to bottom to read their terms of use.

robertodessi commented 7 years ago

Hi, I would like to give my first contribution to this interesting project. Is anybody working on this?

swapagarwal commented 7 years ago

@shaishavgandhi05 Yes, we can use the ChartLyrics API. @robertodessi Sure, go ahead!

kalbhor commented 7 years ago

Hey everyone, though @seongju is right that Genius's API does not directly provide lyrics, but it provides the url of a page that contains the lyrics. Lyrics can be obtained by simply scraping that page. I have sent a Pull Request and have tried adding a lyrics search option which uses Genius's API.

swapagarwal commented 7 years ago

Closed in #149