search

swapagarwal / swag-for-dev

😎 swag opportunities for developers
http://devswag.io
Creative Commons Zero v1.0 Universal
4.25k stars 348 forks source link

Add Applause-button to swag items #104

Open plibither8 opened 5 years ago

plibither8 commented 5 years ago

It would be a simple and nice feature wherein a small applause button accompanies a swag item. Users can '+1' it if they feel this is a nice opportunity, and sorting can then also be done on the basis of the number of applauses an item has got.

Implementation of this is fairly simple: https://applause-button.com/. This allows for Medium-style applause buttons on static websites with a zero-configuration setup.

swapagarwal commented 5 years ago

Neat idea!

swapagarwal commented 5 years ago

As the number of claps comes from the server, how would we embed it into the items array to allow sorting?

plibither8 commented 5 years ago

We'll use the same API method the source code is using: https://github.com/ColinEberhardt/applause-button/blob/master/src/applause-button.js

It'll require a few AJAX calls to fetch the number of claps, and after that it's simple sorting 😄

plibither8 commented 5 years ago

Better yet: just one ajax request will do: https://github.com/ColinEberhardt/applause-button-server/blob/master/src/getMultiple.js

swapagarwal commented 5 years ago

Looks good! Do you want to pick this up?

plibither8 commented 5 years ago

I won't get much time to work on this now because my exams are approaching :/. I'd love to review or help out from time to time though 😀

On Tue, Oct 9, 2018 at 11:34 PM Swapnil Agarwal notifications@github.com wrote:

Looks good! Do you want to pick this up?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/swapagarwal/swag-for-dev/issues/104#issuecomment-428291555, or mute the thread https://github.com/notifications/unsubscribe-auth/AeYr-xcv85rrdHeBiKzC3jAXZtpSEgWoks5ujOUYgaJpZM4XTxaz .

swapagarwal commented 5 years ago

No issues. :)

caseydierking commented 5 years ago

@swapagarwal I'll pick this up.

caseydierking commented 5 years ago

Relinquishing this. Won't be able to get to it.

giordifungula commented 5 years ago

I can take this on :)

pannapat commented 4 years ago

Is this still available to take on?

aslafy-z commented 4 years ago

Hello @pannapat, it's yours! I'll assign you. We have a stale PR at https://github.com/swapagarwal/swag-for-dev/pull/124, please take a look. You might need to synchronize with @anhek since the redesign (https://github.com/swapagarwal/swag-for-dev/pull/443) will happen soon!

pannapat commented 4 years ago

Thanks a lot! Please allow me to look into this for a couple of days.

0xShynn commented 4 years ago

Thanks a lot! Please allow me to look into this for a couple of days.

That's cool 🙂 Don't hesitate to reach me if you need any help for the integration (as I'm in charge of the redesign).

itguymax commented 4 years ago

@anhek the swag-for-dev website is not updated i thought to contribute to some features. anyone here?

itguymax commented 4 years ago

is this still open?

Yash-Garg commented 4 years ago

Great idea 👍

pannapat commented 4 years ago

I’ve been working on this issue! Sorry for not keeping you all posted

On Mon, Nov 25, 2019 at 8:15 AM Yash Garg notifications@github.com wrote:

Great idea 👍

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/swapagarwal/swag-for-dev/issues/104?email_source=notifications&email_token=AB5I63PJONY45FLZRDXQM2TQVPMY5A5CNFSM4F2PC2Z2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCRBMY#issuecomment-558174387, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB5I63LAM2QRKMBNTSTECX3QVPMY5ANCNFSM4F2PC2ZQ .

pannapat commented 4 years ago

Hello @pannapat, it's yours! I'll assign you. We have a stale PR at #124, please take a look. You might need to synchronize with @anhek since the redesign (#443) will happen soon!

@aslafy-z May I ask why we have a stale PR at #124?

pannapat commented 4 years ago

@anhek Should I fork a repo from yours? instead of https://github.com/swapagarwal/swag-for-dev?

0xShynn commented 4 years ago

@anhek Should I fork a repo from yours? instead of https://github.com/swapagarwal/swag-for-dev?

Yes, you should fork my repo which contains the redesign :)

pannapat commented 4 years ago

@anhek Should I fork a repo from yours? instead of https://github.com/swapagarwal/swag-for-dev?

Yes, you should fork my repo which contains the redesign :)

And just branch out from master?

0xShynn commented 4 years ago

Yep, the master branch is the final version of the redesign

pannapat commented 4 years ago

Yep, the master branch is the final version of the redesign

Thanks! The new design looks very cool!

0xShynn commented 4 years ago

Thank you 😊😊

pannapat commented 4 years ago

Do you want one person can hit multiple claps?

0xShynn commented 4 years ago

It's up to the project maintainers to choose but in my opinion, one person can only hit clap once for each opportunity.

pannapat commented 4 years ago

@anhek Is it okay to make one pull request first for adding applause-button with no sorting feature?

0xShynn commented 4 years ago

I think it's okay

pannapat commented 4 years ago

I think it's okay

How can we check that this isn't a new swag opportunity proposal?

pannapat commented 4 years ago

@anhek Please refer to this pull request https://github.com/anhek/swag-for-dev/pull/1 I found one of the tests failed. Looks like it has failed since before the pull request?

0xShynn commented 4 years ago

Sorry for the late reply. The Travis CI test is also failing on my PR request, but when we take a look at the logs, it's about the images references. So it's not up to us ^^

lakshita15 commented 3 years ago

Can you assign me this issue. please Regards, Lakshita