search

swapmyvote / swapmyvote

https://www.swapmyvote.uk
19 stars 16 forks source link

Async load cookieconsent.min.js ? #204

Open coliff opened 4 years ago

coliff commented 4 years ago

currently the cookie consent JS is blocking the page rendering until it loads. Would it work adding the async attribute? Or maybe move that script to the footer of the page so it loads last? Doing so could save approx 930 ms page load time

aspiers commented 4 years ago

Thanks @coliff. Please remember to add the frontend label to your issues. Also if you are able to submit PRs (even untested), that should significantly speed up the time to resolution.

aspiers commented 4 years ago

I've added a new performance label too.

coliff commented 4 years ago

Actually, I would have added labels if I could but I don't think I have the ability to....

aspiers commented 4 years ago

I've just invited you to the github repo dev team.