search

swapnilsparsh / CricketScoreViewer

Cricket Score Viewer (Ipl)
MIT License
2 stars 8 forks source link

Updated the UI of main.py #19

Closed sarthakd999 closed 3 years ago

swapnilsparsh commented 3 years ago

If possible attach the image of the updated UI. @sarthakd999

sarthakd999 commented 3 years ago

okk @swapnilsparsh

sarthakd999 commented 3 years ago

I have added the image in the images folder It is in .png Format

@swapnilsparsh

sarthakd999 commented 3 years ago

It is with name IPL_final.png

@swapnilsparsh

swapnilsparsh commented 3 years ago

You have done great job but you have removed the Dark button and the application is not specified to IPL only , if possible fix these two issue and then make a PR again.@sarthakd999

sarthakd999 commented 3 years ago

okay Sure @swapnilsparsh

sarthakd999 commented 3 years ago

Bro I have just changed the UI of main.py and you are talking about cricbuzz.py

@swapnilsparsh

sarthakd999 commented 3 years ago

please do accept my requrst (PR)

@swapnilsparsh

swapnilsparsh commented 3 years ago

@sarthakd999 Add the Dark function which you have removed then I will accept the PR.

sarthakd999 commented 3 years ago

okkk for sure

@swapnilsparsh

sarthakd999 commented 3 years ago

Hi Captain @swapnilsparsh , I added The feature U wanted on your project

I also added an additional feature which i personally loved to code

u can see the output images in the "images" folder

normal_mode --> when in normal mode dark_mode --> when in dark mode

and btw i updated the "main.py" file

so plz do convey a message about the new feature

Yours Truly Friend, @sarthakd999

sarthakd999 commented 3 years ago

plz accept my request @swapnilsparsh

sarthakd999 commented 3 years ago

Bro I have made efforts to do it just see to it plzz

@swapnilsparsh

swapnilsparsh commented 3 years ago

I will look into your PR but I am facing some problems at my end. Once it will get fixed I will surely look into your contribution. @sarthakd999

sarthakd999 commented 3 years ago

Okk

But Plz check it as early as possible Bcoz time is running

@swapnilsparsh

sarthakd999 commented 3 years ago

U didn't liked the UI of ur Project ???

@swapnilsparsh

swapnilsparsh commented 3 years ago

@sarthakd999 There is a error while running your code. Fix that and then send the PR again

sarthakd999 commented 3 years ago

Bro From my end there is no any error

I will keep my code aside in a new file "IPL.py"

just check that once @swapnilsparsh

sarthakd999 commented 3 years ago

bro see to it the file name is "IPL.py"

@swapnilsparsh

sarthakd999 commented 3 years ago

Please see to it faster bro

@swapnilsparsh

sarthakd999 commented 3 years ago

Because There is no any fault here From my end

Btw what is the problem from ur end @swapnilsparsh

sarthakd999 commented 3 years ago

Have u seen the PR ???

@swapnilsparsh

swapnilsparsh commented 3 years ago

There is a error while running your code, fix the error and then resend the PR. @sarthakd999

sarthakd999 commented 3 years ago

which code are u running can u please tell me ??

bcoz there is no any error in my code

Are u calling blue color an error??

@swapnilsparsh