search

swapnilsparsh / DevEmpire

All in one place where you can find all the resources and details of ambassador/ fellowship, open-source events, web dev sites, games and etc. that are available across different sites.
https://devempire.netlify.app
127 stars 131 forks source link

Illaf #344

Closed Illaf closed 1 year ago

Illaf commented 1 year ago

Description

I have formatted the layout of programs page so that it looks more clean and easily understandable. Please review and merge this pr so that I can apply animations effects on this page according to issue #332 Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #333

Replace issue_no with the issue number which is fixed in this PR

Screenshots

Screenshot (41)

Checklist

netlify[bot] commented 1 year ago

Deploy Preview for devempire ready!

Name Link
Latest commit 15087da96a8e9295e7cdfff30d8429f2b1eaa8ac
Latest deploy log https://app.netlify.com/sites/devempire/deploys/64a9a11af9dcd000089efda7
Deploy Preview https://deploy-preview-344--devempire.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Illaf commented 1 year ago

@isaacplmann @chris--jones Please review this pull request

swapnilsparsh commented 1 year ago

@Illaf there are no changes in layout.

Illaf commented 1 year ago

@swapnilsparsh by layout I mean the designing and spacing that I have added to the programs page as i described in the issue. If you want further changes then you can specify.

swapnilsparsh commented 1 year ago

@swapnilsparsh by layout I mean the designing and spacing that I have added to the programs page as i described in the issue. If you want further changes then you can specify.

As you suggested that page was looking crowded so just by adding margins and padding to the current layout doesnt create a large differene.

Illaf commented 1 year ago

@swapnilsparsh Please if you can specify the changes that you want so it will be easier for me to do the changes. If you agree then I can plan a new design for the page. What do you say?

swapnilsparsh commented 1 year ago

@swapnilsparsh Please if you can specify the changes that you want so it will be easier for me to do the changes. If you agree then I can plan a new design for the page. What do you say?

Plan a new design.

Illaf commented 1 year ago

@swapnilsparsh Please if you can specify the changes that you want so it will be easier for me to do the changes. If you agree then I can plan a new design for the page. What do you say?

Plan a new design.

Okay👍