swapnilsparsh / DevEmpire

All in one place where you can find all the resources and details of ambassador/ fellowship, open-source events, web dev sites, games and etc. that are available across different sites.
https://devempire.netlify.app
126 stars 132 forks source link

Fixed Preloader #425

Closed Nishitbaria closed 11 months ago

Nishitbaria commented 11 months ago

GitHub Pull Request

Fixes ISSUE #418 Description:

I have fixed the issue with the preloader in the DevEmpire website by correcting the image path that was causing the preloader to malfunction. The preloader was failing to display due to an incorrect image path reference. This pull request addresses the issue and ensures that the preloader is displayed as expected.

Changes Made:

I updated the image path in the preloader component to point to the correct location of the loading image. The previous path was causing the preloader to not show up, which has now been resolved by providing the accurate image path.

Testing:

I have tested the preloader thoroughly on different devices and browsers to confirm that the fix has successfully resolved the issue. The preloader now displays correctly during page loading.

Impact:

This fix significantly improves the user experience on the DevEmpire website by ensuring that the preloader works as intended. Users will now see the preloader while the content is being loaded, reducing confusion and enhancing the overall perception of the website's performance.

image

Screenshots:

(Optional: If applicable, you can attach screenshots demonstrating the preloader displaying correctly after the fix.)

I appreciate your review and feedback on this fix. Please let me know if any further adjustments are needed or if there are any concerns related to this pull request.

netlify[bot] commented 11 months ago

Deploy Preview for devempire ready!

Name Link
Latest commit c39a25ea3b8ecc45bab709bce9d19d87dedff307
Latest deploy log https://app.netlify.com/sites/devempire/deploys/64d494e81fb64e00087c383a
Deploy Preview https://deploy-preview-425--devempire.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Nishitbaria commented 11 months ago

@swapnilsparsh ,please review and merge my pull request i have fixed preloader

swapnilsparsh commented 11 months ago

@Nishitbaria As told, add percentage also.

Nishitbaria commented 11 months ago

@swapnilsparsh , i have added percentage loader ,please review and merge my pull request

Nishitbaria commented 11 months ago

@swapnilsparsh , i have added percentage loader ,please review and merge my pull request

swapnilsparsh commented 11 months ago

@Nishitbaria Resolve the conflicts.

Nishitbaria commented 11 months ago

@swapnilsparsh done