swapnilsparsh / Rescue

A women’s safety website that sends emails and messages to your trusted ones.
MIT License
122 stars 191 forks source link

[GSSoc'21]Font sizes are not perfect in phone view #186

Closed arpit456jain closed 3 years ago

arpit456jain commented 3 years ago

Describe the bug

The font size is hard-coded in every tag like h1 and p , it is ok for desktop version but in small screen like phone the text is not clearly visible It is looking like this. screencapture-127-0-0-1-8000-women-rights-2021-03-21-15_43_27

To Reproduce

Expected behavior

The font size should automatically increase in small screen.

Possible solution

https://user-images.githubusercontent.com/55352601/111902662-8785fd00-8a64-11eb-9cb4-e78be8b83e7d.mp4

I am gsoc'21 participant please assign me this issue and allow me to create pull request . I had already done this on my local machine all i have to do is create a pull request if assign to me.

arpit456jain commented 3 years ago

Please assign me this issue i will also modify the font size of other two pages within an hour .

sakshikhachane commented 3 years ago

@arpit456jain Actually there is no such font size problem. It is looking as it is expected to be.

arpit456jain commented 3 years ago

Actually Its was very small in Phone for me when i hosted it and opened it in my phone every thing is very small , no problem if you think it's fine 🙂 you can close this issue.

sakshikhachane commented 3 years ago

@arpit456jain Go ahead with the issue. The font sizes are hard-coded and ideally, it shouldn't be. Happy learning:)

arpit456jain commented 3 years ago

Ok mam Mam can you please add the label of (level)

arpit456jain commented 3 years ago

@sakshikhachane I had almost solve this issue and improve the design of navbar if you notice currently in phone view when we click on toggle button it leave some space on both sides, I had solved it I had fixes the home.html common.html currently working on the files which extends common.html I have a request Please don't Merge any PR until I create a PR otherwise I have to do all changes again Which will be very difficult for me just give me an hour Please

arpit456jain commented 3 years ago

I had replace all inline CSS (which are hard-coded) to internal CSS for easy editing and media queries Please don't merge any PR

arpit456jain commented 3 years ago

@jatinjain001 sir please review the PR #195 before any other PR got merge otherwise i have to do changes again if any conflicts occur

arpit456jain commented 3 years ago

@sakshikhachane mam please review my PR #195

tanishq-arya commented 3 years ago

Please assign this to me under gssoc

sakshikhachane commented 3 years ago

Go ahead @tanishq-arya.

tanishq-arya commented 3 years ago

I'm sorry for the delay. I was not well. Will raise PR by end of the week.