swapnilsparsh / Rescue

A women’s safety website that sends emails and messages to your trusted ones.
MIT License
122 stars 193 forks source link

Fixed Font sizes for mobile view #285

Closed tanishq-arya closed 3 years ago

tanishq-arya commented 3 years ago

Related Issue or bug

Fixes: #186

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

Screenshots

Original Updated
original screenshot updated screenshot
:---------------------------: :

image image image image image image

:|

swapnilsparsh commented 3 years ago

@tanishq-arya Give me some time to review your code.

swapnilsparsh commented 3 years ago

@tanishq-arya Everything is working fine just fix the new pages that were added and then it will be fine.

tanishq-arya commented 3 years ago

There are no photos on the website, fix this bug.

@swapnilsparsh where ? I can see the pictures on my side. image

swapnilsparsh commented 3 years ago

@tanishq-arya Reabse the code and commit it again, might be there is some bug.

tanishq-arya commented 3 years ago

git pull --tags -r Your configuration specifies to merge with the ref 'refs/heads/font-sizes' from the remote, but no such ref was fetched.

swapnilsparsh commented 3 years ago

git pull --tags -r Your configuration specifies to merge with the ref 'refs/heads/font-sizes' from the remote, but no such ref was fetched.

  1. Align the More Details Button in Women's Rights.
  2. Navbar button in Contact Page.
  3. Preloader image is not responsive.
swapnilsparsh commented 3 years ago

SS

tanishq-arya commented 3 years ago

git pull --tags -r Your configuration specifies to merge with the ref 'refs/heads/font-sizes' from the remote, but no such ref was fetched.

  1. Align the More Details Button in Women's Rights.
  2. Navbar button in Contact Page.
  3. Preloader image is not responsive.

@swapnilsparsh

  1. Fixed the button
  2. Navbar button is in the contact page PR
  3. I tried for the preloader but I don't think I can make it work for smaller screens, it overlaps and everything gets disturbed, If you wish I can remove the preloader for smaller screens.
swapnilsparsh commented 3 years ago

@tanishq-arya Try to fix the preloader for the mobile screen if not then tell me I will merge the PR.

tanishq-arya commented 3 years ago

ss

You will fix this bug in this issue or in the contact page issue?

Fixed in contact page.

tanishq-arya commented 3 years ago

@swapnilsparsh I added media queries for the preloader. It was 400px so made it 300px for < 480px widths. If everything is okay, you can merge the PR now.

tanishq-arya commented 3 years ago

@swapnilsparsh I added 2 cols for medium I hope it's okay. Also I added a gap in between rows in mobile view.

swapnilsparsh commented 3 years ago

@swapnilsparsh I added 2 cols for medium I hope it's okay. Also I added a gap in between rows in mobile view.

Still, the bug is there.

tanishq-arya commented 3 years ago

image

tanishq-arya commented 3 years ago

It's okay on my side.

tanishq-arya commented 3 years ago

@swapnilsparsh I added 2 cols for medium I hope it's okay. Also I added a gap in between rows in mobile view.

Still, the bug is there.

Its working fine on my end. Can you check again.

github-actions[bot] commented 3 years ago

Thank you @tanishq-arya for your contribution. Looking forward for more such amazing contributions :)