swapnilsparsh / Rescue

A women’s safety website that sends emails and messages to your trusted ones.
MIT License
122 stars 193 forks source link

created change password page #287

Closed coding-geek21 closed 3 years ago

coding-geek21 commented 3 years ago

Related Issue or bug

Fixes: #197

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

Screenshots

Original Updated
original screenshot updated screenshot

https://user-images.githubusercontent.com/53329034/117149557-f335e680-add4-11eb-8e44-39ca76e86532.mp4

coding-geek21 commented 3 years ago

@sakshikhachane there is some issues with unique email check and username check which is conflicting with register page with email and username when i checked after removing the code for unique email check and username check I can see that the register functionality is working perfectly fine please ask the contributor of #226 to check this , this is why register functionality is not working

coding-geek21 commented 3 years ago

@sakshikhachane i found that the Google auth has expired image This is why it's showing error and login using google is not working , so what should i do now?

Pls update me

sakshikhachane commented 3 years ago

@swapnilsparsh Can you have a look at this?

swapnilsparsh commented 3 years ago

@sakshikhachane i found that the Google auth has expired image This is why it's showing error and login using google is not working , so what should i do now?

Pls update me

Update the API and then check whether it is working or not.

swapnilsparsh commented 3 years ago

@coding-geek21 Is it working now?

coding-geek21 commented 3 years ago

@coding-geek21 Is it working now?

I will update regarding this by today i'm working on it

coding-geek21 commented 3 years ago

@swapnilsparsh I rechecked again by cloning the branch01 and now it's working completely fine can you check it once again and tell me whether you are getting any error?

coding-geek21 commented 3 years ago

And yes this functionality is not working when there is no entry in social applications in Admin page and it works fine if the google api is added

https://user-images.githubusercontent.com/53329034/117848566-0cd9a100-b2a1-11eb-927f-2ed1dc4a929c.mp4

coding-geek21 commented 3 years ago

When i cloned and tried running the code it works fine so I guess there is no issues now

swapnilsparsh commented 3 years ago

@coding-geek21 Push the new commits.

coding-geek21 commented 3 years ago

@coding-geek21 Push the new commits.

@swapnilsparsh Done, Please check whether it's working now , can you check by adding the google-api in the admin page, because after cloning there is no entry in social accounts table that's why it's showing error .

Is login using google working normally in original code?

coding-geek21 commented 3 years ago

@swapnilsparsh I have added the db.sqlite3 file can you check now with google api , It's working now , can you check and tell me

coding-geek21 commented 3 years ago

Please view this demo

https://user-images.githubusercontent.com/53329034/118387875-7b6e8400-b63e-11eb-87a4-5b8eed9f1f32.mp4

And I have one suggestion can you change it to level 3 as i have also worked on backend

swapnilsparsh commented 3 years ago

@coding-geek21 Resolve the conflicts.

coding-geek21 commented 3 years ago

@coding-geek21 Resolve the conflicts.

@swapnilsparsh Done

github-actions[bot] commented 3 years ago

Thank you @coding-geek21 for your contribution. Looking forward for more such amazing contributions :)