swapnilsparsh / Rescue

A women’s safety website that sends emails and messages to your trusted ones.
MIT License
122 stars 193 forks source link

Place all the confidential information in .environement variables #292

Open harshakhmk opened 3 years ago

harshakhmk commented 3 years ago

Describe the bug

Emergency Bug Image

github-actions[bot] commented 3 years ago

Hi 😄, thanks for creating your first issue at RESCUE, do read and follow the Code of Conduct and the Contribution Guidelines while contributing. 🚀

swapnilsparsh commented 3 years ago

@harshakhmk You have to add your email and password in the mail.py file and set your Gmail account to enable less secure apps then this will resolve. If you have done this and then also it's showing, then please let me know.

harshakhmk commented 3 years ago

As I mentioned, we can have a .env file where it would be storing all the email and passwords and other confidential information and we can handle the cases where the required field is empty or invalid, by raising error messages and only send emails when all the credentials are valid, so that load on the sending the mails will be less and that will solve the scalability issues, as Gmail SMTP server can send 500 emails per day when logged into their web interface. Also, It would be good enough if Rescue Team has its own email, and sending emails from it seems more reasonable

coding-geek21 commented 3 years ago

@harshakhmk You have to add your email and password in the mail.py file and set your Gmail account to enable less secure apps then this will resolve. If you have done this and then also it's showing, then please let me know.

Emergency functionality is working fine

swapnilsparsh commented 3 years ago

As I mentioned, we can have a .env file where it would be storing all the email and passwords and other confidential information and we can handle the cases where the required field is empty or invalid, by raising error messages and only send emails when all the credentials are valid, so that load on the sending the mails will be less and that will solve the scalability issues, as Gmail SMTP server can send 500 emails per day when logged into their web interface. Also, It would be good enough if Rescue Team has its own email, and sending emails from it seems more reasonable

Do you want to work on this issue then please rephrase the issue and then let me know?

harshakhmk commented 3 years ago

As I mentioned, we can have a .env file where it would be storing all the email and passwords and other confidential information and we can handle the cases where the required field is empty or invalid, by raising error messages and only send emails when all the credentials are valid, so that load on the sending the mails will be less and that will solve the scalability issues, as Gmail SMTP server can send 500 emails per day when logged into their web interface. Also, It would be good enough if Rescue Team has its own email, and sending emails from it seems more reasonable

Do you want to work on this issue then please rephrase the issue and then let me know?

Yeah I would like to work on this issue, where the rephrased issue is place all the confidential information in .env file

harshakhmk commented 3 years ago

Why EMAIL_BACKEND EMAIL_HOST EMAIL_PORT EMAIL_USE_TLS EMAIL_HOST_USER EMAIL_HOST_PASSWORD DEFAULT_FROM_EMAIL are declared 2 times?

swapnilsparsh commented 3 years ago

Why EMAIL_BACKEND EMAIL_HOST EMAIL_PORT EMAIL_USE_TLS EMAIL_HOST_USER EMAIL_HOST_PASSWORD DEFAULT_FROM_EMAIL are declared 2 times?

Can you please specify the file where it is specified two times?

harshakhmk commented 3 years ago

Why EMAIL_BACKEND EMAIL_HOST EMAIL_PORT EMAIL_USE_TLS EMAIL_HOST_USER EMAIL_HOST_PASSWORD DEFAULT_FROM_EMAIL are declared 2 times?

Can you please specify the file where it is specified two times?

in mysite/settings.py I have created a PR 302 review it @swapnilsparsh