fixed register functionality bug

coding-geek21 commented 3 years ago

Related Issue or bug

fixed the register functionality not working bug

Fixes: #

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write `NA` if there isn't)

A clear and concise description of it.

Checklist:

[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots

Original	Updated
original screenshot	updated screenshot

arpit456jain commented 3 years ago

@coding-geek21 hey I was also thinking about this issue can you please guide me why did you put the condition

if($("#id_username").val() === $("#id_email").val())

unique email and unique username means there should not any duplicate copy of themselves but what's the relation between username and email this condition will never true so the alert will not occur Although the sign in works .

But It doesn't make any sense to me . Correct me If i am getting wrong anything.

Did you check it , by trying to make account with same email again ?

coding-geek21 commented 3 years ago

@coding-geek21 hey I was also thinking about this issue can you please guide me why did you put the condition

if($("#id_username").val() === $("#id_email").val())

unique email and unique username means there should not any duplicate copy of themselves but what's the relation between username and email this condition will never true so the alert will not occur Although the sign in works .

But It doesn't make any sense to me . Correct me If i am getting wrong anything.

Did you check it , by trying to make account with same email again ?

Actually my point of view is anyway this dynamic username functionality is for showing whether the user name and email is available or not using tick and wrong mark , I agree that if($("#id_username").val() === $("#id_email").val()) this is never going to become true I just tried to override by placing that condition , since that only is going to violate the register functionality , and i did this because anyway the django is going to handle it by default when the user tries to register with already existing email and username , so according to me that alert is not necessary and that piece of block is not necessary since it is already checked by django. I will try to give some optimal solution since they have used ajax which i'm not familiar i'm trying to find the correct solution

arpit456jain commented 3 years ago

@coding-geek21 hey I was also thinking about this issue can you please guide me why did you put the condition if($("#id_username").val() === $("#id_email").val()) unique email and unique username means there should not any duplicate copy of themselves but what's the relation between username and email this condition will never true so the alert will not occur Although the sign in works . But It doesn't make any sense to me . Correct me If i am getting wrong anything. Did you check it , by trying to make account with same email again ?

Actually my point of view is anyway this dynamic username functionality is for showing whether the user name and email is available or not using tick and wrong mark , I agree that if($("#id_username").val() === $("#id_email").val()) this is never going to become true I just tried to override by placing that condition , since that only is going to violate the register functionality , and i did this because anyway the django is going to handle it by default when the user tries to register with already existing email and username , so according to me that alert is not necessary and that piece of block is not necessary since it is already checked by django. I will try to give some optimal solution since they have used ajax which i'm not familiar i'm trying to find the correct solution

ok . Actually I have seen this feature in many projects the code is exactly the same , may be the same person added this 😅 But They did not contain this alert part so i think you can remove that if - else containing alert its of no use

github-actions[bot] commented 3 years ago

Thank you @coding-geek21 for your contribution. Looking forward for more such amazing contributions :)

github-actions[bot] commented 3 years ago

Thank you @coding-geek21 for your contribution. Looking forward for more such amazing contributions :)

swapnilsparsh / Rescue