swapnilsparsh / Rescue

A women’s safety website that sends emails and messages to your trusted ones.
MIT License
123 stars 191 forks source link

Activist gallery style updated #336

Closed tanishq-arya closed 3 years ago

tanishq-arya commented 3 years ago

Related Issue or bug

Fixes: #325

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

Screenshots

Original Updated
original screenshot updated screenshot

Screenshot (1706) Screenshot (1707) Screenshot (1705) Screenshot (1704)

tanishq-arya commented 3 years ago

For the text I have added scroll on hover. This looks much better than when I tried with points/lists. image

tanishq-arya commented 3 years ago

Some images are stretching, fix it.

I'll try but they are stretching because the images are of different dimensions.

tanishq-arya commented 3 years ago

image @swapnilsparsh Done. The images look much better and clear now.

tanishq-arya commented 3 years ago

Also I was thinking should I try to modify the cols, make them 2 cols in medium instead of three and make a single row with col wrap.

tanishq-arya commented 3 years ago

image image image

tanishq-arya commented 3 years ago

@swapnilsparsh I have not yet made a fresh pull for this branch as the manage.py file doesn't work. What should I do for the updated master ? Should I pull from upstream and push to my master ?

swapnilsparsh commented 3 years ago

@swapnilsparsh I have not yet made a fresh pull for this branch as the manage.py file doesn't work. What should I do for the updated master ? Should I pull from upstream and push to my master ?

Yes

tanishq-arya commented 3 years ago

git pull --tags upstream master From https://github.com/swapnilsparsh/Rescue

  • branch master -> FETCH_HEAD error: unable to unlink old 'db.sqlite3': Invalid argument

getting this error

tanishq-arya commented 3 years ago

@swapnilsparsh I am getting this image

Should I just stage these changes and make push commit named merge ?

tanishq-arya commented 3 years ago

I fetched and merged from the console in github, but it is not showing here that merge has been made.

tanishq-arya commented 3 years ago

@swapnilsparsh I merged upstream/master into this branch I think you can merge this now if everything is okay.

swapnilsparsh commented 3 years ago

@tanishq-arya Resolve the conflicts.

tanishq-arya commented 3 years ago

@swapnilsparsh this one ? image

tanishq-arya commented 3 years ago

@swapnilsparsh I am unable to fetch any updates because of some database error. I had made a backup branch earlier so I'll make changes to that and raise a new PR.

github-actions[bot] commented 3 years ago

Thank you @tanishq-arya for your contribution. Looking forward for more such amazing contributions :)