swapnilsparsh / Rescue

A women’s safety website that sends emails and messages to your trusted ones.
MIT License
117 stars 182 forks source link

updated readme #339

Closed tanishq-arya closed 3 years ago

tanishq-arya commented 3 years ago

Related Issue or bug

Fixes: #338

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

Screenshots

Original Updated
original screenshot updated screenshot

image

tanishq-arya commented 3 years ago

@swapnilsparsh there were conflicts when I made a fresh PULL. Please check the final readme and let me know if the Linting should be part of installation or it is fine like this only.

tanishq-arya commented 3 years ago

@swapnilsparsh Is the linting part of the installation or is it okay like this.

tanishq-arya commented 3 years ago

Align the lint and format code that is there.

I'll do that. But I am asking if it is like this only ( a different section ) or should I add it in steps in continuation with the installation?

tanishq-arya commented 3 years ago

image I am not familiar with linting. So we've to run both the commands. I should add and between the commands flake and black right?

tanishq-arya commented 3 years ago

Like this image

swapnilsparsh commented 3 years ago

image I am not familiar with linting. So we've to run both the commands. I should add and between the commands flake and black right?

It's already mentioned that it's an alternative.

github-actions[bot] commented 3 years ago

Thank you @tanishq-arya for your contribution. Looking forward for more such amazing contributions :)