Add Candle as a supported chain

[samisbakedham]

Checklist

• [x] I have read the CONTRIBUTING guide
• [x] Good naming (as clear and simple as possible)
• [x] Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
• [x] I tested desktop/mobile resolution
• [x] I tested light/dark theme
• [x] I tested different languages
• [x] I checked the functionality once again (AFFECT MONEY)
• [x] I checked the work on the Testnet
• [x] I checked the work on the Mainnet
• [x] I checked the work in the plugin
• [x] I checked the PR once again

[Disti4ct]

@samisbakedham did you test it?

[samisbakedham]

@samisbakedham did you test it?

Yes

[Disti4ct]

@samisbakedham did you test it?

Yes

I launched this branch and don't see the coin or tokens for this network

[samisbakedham]

@samisbakedham did you test it?

Yes

I launched this branch and don't see the coin or tokens for this network

I'll check and fix!

[Disti4ct]

@samisbakedham please don't mark checkboxes if you don't complete them

[samisbakedham]

@samisbakedham please don't mark checkboxes if you don't complete them

Fixed, and will push soon'

[samisbakedham]

@NotEternal How does it look now on your end? The tests I ran checked out

[Disti4ct]

@samisbakedham you don't have candle_ApiKey anywhere. If you don't have network API, just leave an empty string for cndlscan and candle_ApiKey. If you have API, then use these keys everywhere: cndl_ApiKey, cndlscan

[Disti4ct]

@samisbakedham for the testing I need:

• CNDL amount (for example 1)
• some token amount (any 10 tokens)
• two tokens from existing pool in dex.CNDLchain.com (also 10 each of them)

Send it to this address: 0x4086a2CAe8d3FcCd94D1172006516C7d0794C7Ee

[samisbakedham]

@samisbakedham for the testing I need:

• CNDL amount (for example 1)

• some token amount (any 10 tokens)

• two tokens from existing pool in dex.CNDLchain.com (also 10 each of them)

Send it to this address: 0x4086a2CAe8d3FcCd94D1172006516C7d0794C7Ee

I'll work on fixing the highlighted code you reviewed, thank you and just sent the tokens for testing now.

[Disti4ct]

add CNDL here: file

[Disti4ct]

Wrong link source:

[samisbakedham]

Wrong link source:

Wrong link source?

[samisbakedham]

add CNDL here: file

Done

[Disti4ct]

• I cannot see CNDL coin in the internal wallet after selecting it here:

• Maybe the same reason for this bug, I cannot see and update my CNDL balance in Quickswap:

• Cannot see CNDL in a Deposit window and smth weard with background:

• Problem in direct swap. Trying to swap CNDL with DAI. The second input is empty and we can see this error: amountOut Error: Returned error: execution was reverted

[Disti4ct]

I disable CNDL in the testnet config, but still see a tokens option in the "Create a wallet" screen:

[samisbakedham]

• I cannot see CNDL coin in the internal wallet after selecting it here:
• Maybe the same reason for this bug, I cannot see and update my CNDL balance in Quickswap:
• Cannot see CNDL in a Deposit window and smth weard with background:
• Problem in direct swap. Trying to swap CNDL with DAI. The second input is empty and we can see this error: amountOut Error: Returned error: execution was reverted

It works now I think

[Disti4ct]

@samisbakedham you cannot lounch and test it? Please do it yourself first.

[samisbakedham]

@samisbakedham you cannot lounch and test it? Please do it yourself first.

I tested it and it works for me

[Disti4ct]

strange, then send a short video with CNDL wallet addition

[samisbakedham]

strange, then send a short video with CNDL wallet addition

Will do, do you have a discord we can chat with?

[Disti4ct]

strange, then send a short video with CNDL wallet addition

Will do, do you have a discord we can chat with?

Just send it here. It has to be not longer then several seconds. The moment when you add CNDL in the wallet.

[samisbakedham]

strange, then send a short video with CNDL wallet addition

Will do, do you have a discord we can chat with?

Just send it here. It has to be not longer then several seconds. The moment when you add CNDL in the wallet.

[samisbakedham]

strange, then send a short video with CNDL wallet addition

Will do, do you have a discord we can chat with?

Just send it here. It has to be not longer then several seconds. The moment when you add CNDL in the wallet.

[Disti4ct]

On your screen is an external wallet (Metamask in this case). With external wallets we don't have problems. I'm talking about internal wallet, when you just started and create it from the "Create a wallet" screen.

[samisbakedham]

On your screen is an external wallet (Metamask in this case). With external wallets we don't have problems. I'm talking about internal wallet, when you just started and create it from the "Create a wallet" screen.

Ah. I'll check now

[samisbakedham]

On your screen is an external wallet (Metamask in this case). With external wallets we don't have problems. I'm talking about internal wallet, when you just started and create it from the "Create a wallet" screen.

[Disti4ct]

@samisbakedham do you use this app? If so maybe it's easier to use your fork instead. You already fork it.

[samisbakedham]

@samisbakedham do you use this app? If so maybe it's easier to use your fork instead. You already fork it.

I'm trying to add support for it in the main repo for others too

[Disti4ct]

@samisbakedham I was talking with a team and your network does not match for integration possibility. You can check requirements here: https://support.onout.org/hc/1331700057/32/addnewnetwork?category_id=8

[samisbakedham]

Wut

[Disti4ct]

Wut

In the link above you can see the list of required network properties. This network has to have it (we cannot add any networks or networks in too early stages for security reasons).

[noxonsu]

will reopen if need. you've tried, thank you