swapper-org / NodeChain

Nodechain is a service that allows you to create nodes on a blockchain and connect to them natively through APIs. The goal is to allow the user to build their own nodes natively without having to rely on external services.

MIT License

7 stars 5 forks source link

Update getFeePerByte from kb to byte #102

Closed phoenix-web3 closed 2 years ago

phoenix-web3 commented 2 years ago

Description

After researching, we conclude that EstimateSmartFee returns the amount in KB. Now the amount is returned in sat/byte

Fixes #75 (issue)

Dependencies (if any)

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

{'feePerByte': '1'}

Test Configuration:

Operating system (output of cat /etc/os-release):
Kernel version (output of uname -sr):
Architecture (output of uname -m):

Related PR or Docs PR

Docs PR related # Other PR related #

Good practices to consider

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules