swapper-org / NodeChain

Nodechain is a service that allows you to create nodes on a blockchain and connect to them natively through APIs. The goal is to allow the user to build their own nodes natively without having to rely on external services.

MIT License

7 stars 5 forks source link

119 mainnets are failing with testnet #122

Closed phoenix-web3 closed 2 years ago

phoenix-web3 commented 2 years ago

Description

[x] Change LUNA host to accept requests by network
[x] Change BCH host to accept requests by network
[x] Change BTC host to accept requests by network
[x] Change ETH host to accept requests by network
[x] Change XMR host to accept requests by network

Also done:

Change BCH main service name from bitcoincore to bitcoinabc
Add logger for admin requests in scripts/endpoints.py
Increase the max complexity by 1 (script needed)
Update getBlockByHash and getBlockByNumber schemas
Fix unused LUNA and BCH method from handler.py
Remove hardcoded coins
Fixed typo in syncing method

Fixes #119 #120 (issue)

Dependencies (if any)

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Related PR or Docs PR

Docs PR related # Other PR related #

Good practices to consider

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

phoenix-web3 commented 2 years ago

@bridgedragon Before merging this PR, can you test it on the server?

I suggest to use the new server. I've fixed some path bugs in the docker volumes of Bitcoin. This could break the synced volumes