Description

~If you specify RPC port as 80 or 443, this port won't be added to the URL.~

~This change applies to every currency excepts XMR. This is because the formation of the URL in XMR is different~

Changed the architecture of configuration parameters. Now you only need to pass an URL to configure any API with your own server.
Changed .availableCurrencies.json with the new configurable params
Removed defaultConf.json dependencies from the Connector
Changed BTC and ETH tests with the new changes
Create a new file with the "default configuration" for the startup script.
Now the sysadmin can copy templateConfig.json and rename it to config.json to use default parameters.

Fixes #124 (issue)

Dependencies (if any)

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Old tests before changing the whole configuration architecture

Old tests

Test Infura connection

$ ./nodechain.py start
---------------------------------------------------
  _  _          _        ___  _                   
 | \| | ___  __| | ___  / __|| |_   __ _ (_) _ _  
 | .` |/ _ \/ _` |/ -_)| (__ | ' \ / _` || || ' \ 
 |_|\_|\___/\__,_|\___| \___||_||_|\__,_||_||_||_|
---------------------------------------------------
===================================================
                CONNECTOR CONFIG
===================================================
Port to start: 60000
Port to start (SSL): 443
Starting network nodechain-network.
nodechain-network is already started
Starting connector and reverse proxy... This might take a while.
Connector has been started
===================================================
                BLOCKCHAIN SELECTION
===================================================
[OFF]          1.Bitcoin
[OFF]          2.Ethereum
[OFF]          3.Bitcoin-cash
[OFF]          4.Terra
               5.Exit
Please choose the blockchain that you want to use to build up/stop the node(1-5): 2
===================================================
                NETWORK SELECTION
===================================================
[OFF]          1.Regtest
[OFF]          2.Testnet
[OFF]          3.Mainnet
               4.Exit
Please choose the network that you want to use (1-4): 2
Please choose the directory to save blockchain data (/srv/nodechain-node/eth_testnet): 
Starting ethtestnetapi node... This might take a while.
ethtestnetapi node started
Do you want to configure your API  [y/N]: y
Please, introduce a value for rpcEndpoint: https://ropsten.infura.io/v3/xxxxxxxxxxxxxxxxxxx1592
Please, introduce a value for wsEndpoint: wss://ropsten.infura.io/ws/v3/xxxxxxxxxxxxxxxxxxx1592
eth testnet has registered succesfully in the connector

imagen

Related PR or Docs PR

Docs PR related # Other PR related #

Good practices to consider

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

swapper-org / NodeChain

Prevent to add port to url if port is 80 or 443 #125