search

swar / Swar-Chia-Plot-Manager

This is a Cross-Platform Plot Manager for Chia Plotting that is simple, easy-to-use, and reliable.
GNU General Public License v3.0
1.25k stars 388 forks source link

New official pool support / nftpool support #1224

Closed jack60612 closed 3 years ago

jack60612 commented 3 years ago

The new pool_url variable allows the use of Pool Contract Address Refer to https://github.com/Chia-Network/chia-blockchain/wiki/Pooling-FAQ#how-do-i-assign-portable-plots-to-a-pool

Tested and working on linux and windows

jack60612 commented 3 years ago

@swar

mladenperisic commented 3 years ago

@jack60612 Hey, Jack! I like this PR! How about you merge this PR https://github.com/swar/Swar-Chia-Plot-Manager/pull/1139/files from @jchristman75 in your fork?

jack60612 commented 3 years ago

@mladenperisic i do understand where you are coming from. however i would like to get this fork merged as soon as possible so i'm probably not going to do that

TomasVelPar commented 3 years ago

@jack60612 thank you so much. I have made those modifications to the original code and its working for me.

adobito commented 3 years ago

@jack60612 I tried running your branch and was having super weird issues that I had to debug. I kept my pool_public_key in the config.yaml and just added my pool_url but it didn't seem to be working. After debugging, I found out the the process exits/dies with this error RuntimeError: Choose one of pool_contract_address and pool_public_key but it hangs as a defunct process, so Swar sees the PID still running and it causes weird behavior. Swar gives 0 feedback right now on this and I think most people would not be able to debug this on their own if they ran into the same issue.

TomasVelPar commented 3 years ago

I think you must delete (or comment) your pool_public_key, and is not the pool url, its your pool contract address (you can obtaint it making a plot with chia gui, deleting it after few seconds and checking que plot log).

@jack60612 I tried running your branch and was having super weird issues that I had to debug. I kept my pool_public_key in the config.yaml and just added my pool_url but it didn't seem to be working. After debugging, I found out the the process exits/dies with this error RuntimeError: Choose one of pool_contract_address and pool_public_key but it hangs as a defunct process, so Swar sees the PID still running and it causes weird behavior. Swar gives 0 feedback right now on this and I think most people would not be able to debug this on their own if they ran into the same issue.

adobito commented 3 years ago

I think you must delete (or comment) your pool_public_key, and is not the pool url, its your pool contract address (you can obtaint it making a plot with chia gui, deleting it after few seconds and checking que plot log).

@jack60612 I tried running your branch and was having super weird issues that I had to debug. I kept my pool_public_key in the config.yaml and just added my pool_url but it didn't seem to be working. After debugging, I found out the the process exits/dies with this error RuntimeError: Choose one of pool_contract_address and pool_public_key but it hangs as a defunct process, so Swar sees the PID still running and it causes weird behavior. Swar gives 0 feedback right now on this and I think most people would not be able to debug this on their own if they ran into the same issue.

The point I was trying to make is that this is a problem and the plot manager should catch this.

jack60612 commented 3 years ago

I think you must delete (or comment) your pool_public_key, and is not the pool url, its your pool contract address (you can obtaint it making a plot with chia gui, deleting it after few seconds and checking que plot log).

@jack60612 I tried running your branch and was having super weird issues that I had to debug. I kept my pool_public_key in the config.yaml and just added my pool_url but it didn't seem to be working. After debugging, I found out the the process exits/dies with this error RuntimeError: Choose one of pool_contract_address and pool_public_key but it hangs as a defunct process, so Swar sees the PID still running and it causes weird behavior. Swar gives 0 feedback right now on this and I think most people would not be able to debug this on their own if they ran into the same issue.

yep i made this code 10 days ago before this was clear so im fixing it now

125devin commented 3 years ago

Is it necessary to keep the 'pool_public_key' variable? Is the '-p' flag needed for anything?

Would changing one letter in the file pools.py do the trick for updating to chia 1.2 pools?

    flags['p'] = pool_public_key

to flags['c'] = pool_public_key

Would the pool_public_key variable in the config.yaml file then work for the new "pool contract key"?

jack60612 commented 3 years ago

Is it necessary to keep the 'pool_public_key' variable? Is the '-p' flag needed for anything?

Would changing one letter in the file pools.py do the trick for updating to chia 1.2 pools?

    flags['p'] = pool_public_key

to flags['c'] = pool_public_key

Would the pool_public_key variable in the config.yaml file then work for the new "pool contract key"?

Backwards compatibility If swar wants he can remove it but i dont think its my place to

swar commented 3 years ago

@jack60612 can you add a placeholder to the Russian README as well and I will get this merged out soon

jack60612 commented 3 years ago

@jack60612 can you add a placeholder to the Russian README as well and I will get this merged out soon

added