search

swar / Swar-Chia-Plot-Manager

This is a Cross-Platform Plot Manager for Chia Plotting that is simple, easy-to-use, and reliable.
GNU General Public License v3.0
1.25k stars 388 forks source link

Fix starting a new plot even if the destination disk is full #1253

Closed ToRvaLDz closed 3 years ago

ToRvaLDz commented 3 years ago

The destination free space must be checked inside the jobs loop otherwise after the first job starts the second one will not consider the first one.

Furthermore the work.destination_drive and work.k_size are not filled with the job values and the final trailing slash on the drive name, introduced with madmax, must be removed.

bilalwaheedch commented 3 years ago

Just tested this PR and it is working fine for me. Thank you! Ubuntu 20.04.2 LTS

swar commented 3 years ago

The destination free space must be checked inside the jobs loop otherwise after the first job starts the second one will not consider the first one.

Furthermore the work.destination_drive and work.k_size are not filled with the job values and the final trailing slash on the drive name, introduced with madmax, must be removed.

You're doing good work!

Leemonn commented 3 years ago

Not working fine for me Ubuntu 21.04. I'm trying to check the debug.log but it has like 1gb of information. Will see if I can upload the before and after of the checks

Leemonn commented 3 years ago

Here is the debug.log

2021-08-02 18:32:52 [INFO]: Free space before checking active jobs: {'/home/test/Desktop/disks-plots/plots1': 4586253213696, '/home/test/Desktop/disks-plots/plots2': 6804220346368, '/home/test/Desktop/disks-plots/plots3': 2694762844160, '/home/test/Desktop/disks-plots/plots4': 6804245041152, '/home/test/Desktop/disks-plots/plots5': 6913136066560, '/home/test/Desktop/disks-plots/plots6': 7021848891392, '/home/test/Desktop/disks-plots/plots7': 4586298322944, '/home/test/Desktop/disks-plots/plots8': 8477057806336, '/home/test/Desktop/disks-plots/plots9': 1280004595712, '/home/test/Desktop/disks-plots/plots10': 191685828608}
2021-08-02 18:32:52 [INFO]: /home/test/Desktop/disks-plots/plots9
2021-08-02 18:32:52 [INFO]: /home/test/Desktop/disks-plots/plots10
2021-08-02 18:32:52 [INFO]: /home/test/Desktop/disks-plots/plots2
2021-08-02 18:32:52 [INFO]: /home/test/Desktop/disks-plots/plots4
2021-08-02 18:32:52 [INFO]: /home/test/Desktop/disks-plots/plots1
2021-08-02 18:32:52 [INFO]: /home/test/Desktop/disks-plots/plots3
2021-08-02 18:32:52 [INFO]: /home/test/Desktop/disks-plots/plots5
2021-08-02 18:32:52 [INFO]: /home/test/Desktop/disks-plots/plots8
2021-08-02 18:32:52 [INFO]: /home/test/Desktop/disks-plots/plots6
2021-08-02 18:32:52 [INFO]: /home/test/Desktop/disks-plots/plots7
2021-08-02 18:32:52 [INFO]: Free space after checking active jobs: {'/home/test/Desktop/disks-plots/plots1': 4477253213696, '/home/test/Desktop/disks-plots/plots2': 6695220346368, '/home/test/Desktop/disks-plots/plots3': 2585762844160, '/home/test/Desktop/disks-plots/plots4': 6695245041152, '/home/test/Desktop/disks-plots/plots5': 6804136066560, '/home/test/Desktop/disks-plots/plots6': 6912848891392, '/home/test/Desktop/disks-plots/plots7': 4477298322944, '/home/test/Desktop/disks-plots/plots8': 8368057806336, '/home/test/Desktop/disks-plots/plots9': 1171004595712, '/home/test/Desktop/disks-plots/plots10': 82685828608}
2021-08-02 18:32:52 [INFO]: Checking to queue work for job: 2c-16t-10
2021-08-02 18:32:52 [INFO]: Total jobs in phase 1: 0
2021-08-02 18:32:52 [INFO]: Starting new plot for job: 2c-16t-10
2021-08-02 18:32:52 [INFO]: Job log file path: /home/test/Desktop/Swar-Chia-Plot-Manager/logs/2c-16t-10_2021-08-02_18_32_52_957984.log
2021-08-02 18:32:52 [INFO]: Checking for full destinations.
2021-08-02 18:32:52 [INFO]: Drive "/home/test/Desktop/disks-plots/plots1" has 4477253213696 free space.
2021-08-02 18:32:52 [INFO]: Job temporary directory: /home/test/Desktop/discos/ploteo1/plots10/
2021-08-02 18:32:52 [INFO]: Job destination directory: /home/test/Desktop/disks-plots/plots10/
2021-08-02 18:32:52 [INFO]: Job temporary2 directory: None
2021-08-02 18:32:52 [INFO]: Starting with plot command: ['/home/test/Desktop/chia-plotter/build/chia_plot', '-r', '28', '-t', '/home/test/Desktop/discos/ploteo1/plots10/', '-d', '/home/test/Desktop/disks-plots/plots10/', '-u', '512', <Removed keys>]
2021-08-02 18:32:52 [INFO]: Starting process
2021-08-02 18:32:53 [INFO]: Started process: 512941
2021-08-02 18:32:53 [INFO]: Setting priority level: 0
2021-08-02 18:32:53 [INFO]: Set priority level
2021-08-02 18:32:53 [INFO]: Setting process cpu affinity: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29]
2021-08-02 18:32:53 [INFO]: Set process cpu affinity
2021-08-02 18:32:53 [INFO]: Job total running: 2
2021-08-02 18:32:53 [INFO]: Job running: [465241, 512941]
2021-08-02 18:32:53 [INFO]: Sleeping for 30 seconds.
2021-08-02 18:33:23 [INFO]: Checking log progress..
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 465115
2021-08-02 18:33:23 [INFO]: PID still alive: 465115
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 465241
2021-08-02 18:33:23 [INFO]: PID still alive: 465241
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 472550
2021-08-02 18:33:23 [INFO]: PID still alive: 472550
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 472551
2021-08-02 18:33:23 [INFO]: PID still alive: 472551
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 483849
2021-08-02 18:33:23 [INFO]: PID still alive: 483849
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 483850
2021-08-02 18:33:23 [INFO]: PID still alive: 483850
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 491603
2021-08-02 18:33:23 [INFO]: PID still alive: 491603
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 492055
2021-08-02 18:33:23 [INFO]: PID still alive: 492055
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 502730
2021-08-02 18:33:23 [INFO]: PID still alive: 502730
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 502817
2021-08-02 18:33:23 [INFO]: PID still alive: 502817
2021-08-02 18:33:23 [INFO]: Checking log progress for PID: 512941
2021-08-02 18:33:23 [INFO]: PID still alive: 512941
2021-08-02 18:33:23 [INFO]: Clearing zombies

As you can see /home/test/Desktop/disks-plots/plots10/ has only 82.6 GB of space, not enough for a k32 plot.

Something weird happens there, job 2c-16t-10 has destination drive /home/test/Desktop/disks-plots/plots10/ but when checking for full destinations Swar is checking /home/test/Desktop/disks-plots/plots1 only?

I'm not sure if Swar is ignoring the other 9 destination folder of if it's confusing /home/test/Desktop/disks-plots/plots10/ with /home/test/Desktop/disks-plots/plots1/ for some reason