search

swar / nba_api

An API Client package to access the APIs for NBA.com
MIT License
2.34k stars 515 forks source link

update ScoreBoard game_date property name to score_board_date #422

Closed brooklynbagel closed 5 months ago

brooklynbagel commented 5 months ago

minor PR but it looks like there's a mismatch in the documented property name for the game in ScoreBoard(), and the implementation. The docs say .game_date but it's implemented as .score_board_date. Alternatively, I can instead change what's in https://github.com/swar/nba_api/blob/5853b5469c436d9489ef355235209daa3a300bba/src/nba_api/live/nba/endpoints/scoreboard.py to switch from scoreboard_game_date to game_data but I figured this change to the docs would be less risky.

rsforbes commented 5 months ago

@brooklynbagel - Thanks for the update. Merged!