search

swar / nba_api

An API Client package to access the APIs for NBA.com
MIT License
2.54k stars 542 forks source link

[Bug]: Incorrect Data for Team Rankings #441

Closed AdityaRao127 closed 1 month ago

AdityaRao127 commented 6 months ago

NBA API Version

1.4.1

Issue

All team-ranked categories return 1, for the 2023-24 NBA season.

For example, these gave 1st rank for all 30 teams, when tested several times:

This data is supposed to be accessible through the teamdashboardbyshootingsplits.py and teamdashboardbygeneralsplits.py

Sidenote -- the Bug Report guide details has a typo. It should say Contributing to the NBA API instead of Contributing **tot he** NBA API

Code

No response

rsforbes commented 5 months ago

@AdityaRao127 - Will get this look at this weekend.

AdityaRao127 commented 1 month ago

Hi @rsforbes , just wanted to check in on this.

rsforbes commented 1 month ago

@AdityaRao127 - Apologies for the delay. Finally got around to running the code.

Educated Guess: Because you are pulling a single team, which is the intent of the call, all teams ranks will be 1. The reason? There is only one team, and that team ranks first. What does it mean? The fields are essentially useless.

Site Location: In general, ever call has some type of web page in front of it. I was able to locate the TeamDashboardByShootingSplits and TeamDashboardByGeneralSplits on the following pages:

Of interest you to is the lack of rank on these pages futher indicating that what is being returned in the response is likely just irrelevant data.

If you are trying to rank teams, depending on your work, you might look at the LeagueDashTeamStats call. It may provide the data you seek. LeagueDashTeamStats is one of the main stats pages for teams.

Hopefully that helps put some context around the calls you are using and perhaps provides an alternative.