swaraj-das / Collect-your-GamingTools

E-Commerce Website for Gaming Tools
https://collect-your-gamingtools.netlify.app/
MIT License
51 stars 226 forks source link

[BUG] Issues In style.css and script.js #132

Open rimmon1234 opened 1 month ago

rimmon1234 commented 1 month ago

Description

1)Repeated Background Definition: button has two background definitions, which are redundant. You only need one.

2)Improvment of Media Queries:Adding another breakpoint for larger screens, e.g desktops above 1440px, to handle ultra-wide or high-resolution screens.

3)Animations Optimization: Adding will-change to animating elements (e.g., the rainbow effect) can optimize browser performance when handling complex CSS animations.

4)Inefficient DOM Access: In the scroll event listener, you repeatedly access the DOM for scrollTopButton. It's better to store the DOM element in a variable outside the scroll event, so the DOM is not queried on every scroll action.

5)Toggle Button Issue: The toggleMenu function compares the maxHeight value with "0px", which could sometimes be "0" or other forms depending on the browser and situation.

assign me the task so I can work on these issues

Screenshots

No response

Any additional information?

No response

What browser are you seeing the problem on?

Google Chrome

Checklist

rimmon1234 commented 1 month ago

i have fixed the issue please checkout @swaraj-das