search

swarm-game / swarm

Resource gathering + programming game
Other
828 stars 52 forks source link

[Editor] Use hoistMaybe #1151

Open kostmo opened 1 year ago

kostmo commented 1 year ago

See code comment:

https://github.com/swarm-game/swarm/blob/6abe9c241b4a59d8707c3ed5db9924fb34649035/src/Swarm/TUI/Editor/Controller.hs#L60-L61

Hackage: https://hackage.haskell.org/package/transformers-0.6.1.1/docs/Control-Monad-Trans-Maybe.html#v:hoistMaybe

byorgey commented 1 month ago

To clarify this issue, it involves:

  1. Refactor to use hoistMaybe anywhere we are currently using something like MaybeT . pure directly (like the place shown above)
  2. Depend on transformers >= 0.6 and remove our own definition of hoistMaybe from Swarm.Util.
nitinprakash96 commented 1 month ago

To add more, we can depend on transformers >= 0.6 once we drop support for GHC <= 9.4.8. See #1996 for context on why it so.