swarm-game / swarm

Resource gathering + programming game
Other
820 stars 51 forks source link

Apply bindings before returning unification mismatch error #1972

Closed byorgey closed 1 week ago

byorgey commented 1 week ago

Closes #1888. When we discovered a type mismatch, we were not fully substituting everything we had learned about the types (via applyBindings) before reporting the error. For example, in #1888 we had 2 : u1 and a unification constraint u1 = Int -> u2, but we were just reporting the type of 2 as u1 rather than first substituting Int -> u2 for u1.

I think we have had this problem for a while, but the recent rewrite of the unification engine possibly made the effects more noticeable.

This incidentally improved a couple more error messages in the test suite. =)