search

swarm-lab / editR

A Rmarkdown editor with instant preview
GNU General Public License v3.0
350 stars 30 forks source link

Different header types are not respected #1

Closed daattali closed 9 years ago

daattali commented 9 years ago

Whether I use # or ## or ### or #### all result in the same size in the preview panel (of course, when actually rendering the rmarkdown using pandoc, it looks correct)

sjmgarnier commented 9 years ago

Thanks. I'll look into it asap.

sjmgarnier commented 9 years ago

Ok, it should work now. It was just a problem with the css. I also added automatic numbering in preview.

See changes at: https://github.com/swarm-lab/editR/commit/ce1041d54c2dbd42eb11963453f9e8499feaf4c7

daattali commented 9 years ago

Awesome :) When I have a commit that fixes an issue, I like to link to the issue in the commit so that on this page it'll show exactly what's the code that fixed it. Nice css skills

sjmgarnier commented 9 years ago

Google is entirely responsible for my css skills :-)

By linking the issue in the commit, you mean just add the link in the commit message? Or something else? My git skills are still very limited :-)

daattali commented 9 years ago

https://help.github.com/articles/closing-issues-via-commit-messages/
I think this is more of a GitHub rather than git thing, but it's pretty awesome. It automatically closes your issue and also adds a link in the issue to the commit

sjmgarnier commented 9 years ago

I guess it'll be for next time. I read that it's bad practice (maybe not possible) to modify the commit message after pushing it to remote. For now I'll just add the link manually in the comment closing this issue. Thanks for the tip though, it'll come in handy in the future.

daattali commented 9 years ago

Oh for sure, do not modify a commit, it can get ugly and weird. Was just a tip for the future

On Sat, Jan 10, 2015 at 7:30 PM, Simon Garnier notifications@github.com wrote:

I guess it'll be for next time. I read that it's bad practice (maybe not possible) to modify the commit message after pushing it to remote. For now I'll just add the link manually in the comment closing the this issue. Thanks for the tip though, it'll come in handy in the future.

— Reply to this email directly or view it on GitHub https://github.com/swarm-lab/editR/issues/1#issuecomment-69482241.