search

swarm64 / s64da-benchmark-toolkit

Swarm64 DA Benchmark Toolkit
https://swarm64.com/
MIT License
30 stars 12 forks source link

Format code with Black #113

Closed 0xfeedface closed 2 years ago

sdressler commented 3 years ago

General comment: What is the point of replacing ' with "? Is it more safe/compliant with python?

Actually, according to PEP-8, the default quote for strings should be '. But typically, people use " when they need to show ' inside the string.

0xfeedface commented 3 years ago

Its a decision by Black that all strings should be double-quoted to make Python code look similar to C code. I am not a fan of it but that's what the tool does.

sdressler commented 3 years ago

Ok, and someone/we opted for Black and not e.g. something that does PEP-8?

0xfeedface commented 3 years ago

We opted to use Black for our code. See this as a proposal that you can reject if you don't like it.

sdressler commented 3 years ago

Well, IMO public Python code should be in accordance with PEP-8 as this is the commonly used standard. But that is my personal opinion.

oferz commented 3 years ago

Well, IMO public Python code should be in accordance with PEP-8 as this is the commonly used standard. But that is my personal opinion.

According to the black website, it is PEP-8 compliant.