search

swarm64 / s64da-benchmark-toolkit

Swarm64 DA Benchmark Toolkit
https://swarm64.com/
MIT License
30 stars 12 forks source link

Bugfix/sdb 9074 si toolkit benchmarking reports success even when something fails #91

Closed saidkarim closed 4 years ago

saidkarim commented 4 years ago

After the PR is approved, I'll format s64da_benchmark_toolkit/prepare.py with black

saidkarim commented 4 years ago

Can you also create a unit test for this?

It's very difficult. Because the data generation and copy command come together from prepare.py. I don't know how to separate them. Returning zero from this command in a unit test for me doesn't make sense.