search

swarmcity / SwarmCityDapp

Swarm City dApp FrontEnd
MIT License
28 stars 10 forks source link

Parameters are only updated on first load #770

Closed hershkoy closed 6 years ago

hershkoy commented 6 years ago

Location

many pages

Expected behavior

If a 'global' parameter, for example the username, is changed on another page, it should be updated 'globally'

Actual behavior

Parameters are updated only on first page load, and as a result, if they are changed on another page, the second time user gets into the page, the parameter will show the previous value.

Steps to reproduce the problem

one place where this has been seen: avatar and username are not cleared when aborting the new account flow, when i create a new account and don't choose a custom avatar or username, and proceed, the previous username and avatar appear at the end of the new account flow.

Operating system / hardware

all os

kikipluche commented 6 years ago

@hershkoy isn't it important to mention that this is not the case on the current master, but only on the branch where you are trying to fix the "create account second time "bug? Or am I mistaken somehow?

hershkoy commented 6 years ago

I believe that this issue is general, however I truly don't know if this issue creates more bugs. Every component or page that updates its parameters just on first load can have this bug on the second time it is loaded into view.

Specifically we detected the bug it caused on 762 branch, but it can cause other bugs in other places that we haven't discovered yet.

@xardass requested that I open a separate issue for it, so we can think about the implications.