search

swarmcity / SwarmCityDapp

Swarm City dApp FrontEnd
MIT License
28 stars 10 forks source link

json backup doesn't work #807

Closed kikipluche closed 6 years ago

kikipluche commented 6 years ago

Location

make backup

Expected behavior

when choosing the download option, the file gets downloaded before being able to proceed

Actual behavior

proceeded, but file wasn't stored on the phone

Steps to reproduce the problem

create account, backup json file

Operating system / hardware

android chrome Samsung galaxy 7

kikipluche commented 6 years ago

while testing I encountered this on a laptop/phoneview, when creating a new account, or when downloading a backup, in both cases i get the feedback that a backuop was successfully created, but there is no download made.

xardass commented 6 years ago

Good, I'm assigning this to myself

xardass commented 6 years ago

@bkawk I leave this to you? It's only on mobile view (chrome dev or real phone), no download actually takes place.

kikipluche commented 6 years ago

@bkawk it is more than only on mobile, the json that is downloaded atm on desktop doesn't have the right content, so unable to restore...

kikipluche commented 6 years ago

@bkawk it is more than only on mobile, the json that is downloaded atm on desktop doesn't have the right content, so unable to restore...

and now it does generate a correct json again. So never mind this comment.

kikipluche commented 6 years ago

@bkawk and today , i am again unable to make the backup , no file is downloaded, but i get the success-page. Needs some investigation, because this is an important element of the app.

xardass commented 6 years ago

@kikipluche Will pushed a fix (@bkawk), please verify

kikipluche commented 6 years ago

@bkawk i wasn't able to create a backup, i didn't get the download option. I refreshed and tried in different views (desktop, mobile, ... ).

kikipluche commented 6 years ago

well, apparently it works for everyone else. We need to doublecheck on the iphone. If we provide a download button, it has to be functional. If not, we provide the checkmark to say you'll use the private key as a backup @bkawk

bkawk commented 6 years ago

@kikipluche I have added the tick box for ios, so the user must confirm that they have copied their keys before taking them to the hashtag list page. This works on the emulator please can you check it works on a real device.