swarmcity / sc-boardwalk

NO LONGER ACTIVE, current development of dApp in SwarmCitySite
25 stars 13 forks source link

refactor all 'this.shadowRoot.getElementById' selectors to this.$. selectors #295

Open sponnet opened 7 years ago

sponnet commented 7 years ago

Environment

MacOS / Safari ( probably Iphone safari too )

Actual behavior:

lot of console logs when evaluating these shadowRoot selectors - probably leading to other errors ( visual and/or functional )

Expected behavior:

replace selectors with this.$. selectors , add appropriate ID's to the selected elements

Steps to reproduce the problem:

Open app in safari - log in - check console

Console Output (if possible):

Go to developer tools, and select Console copy the Output below

Output
sponnet commented 7 years ago

Occurrences in the code

sponnet commented 7 years ago

Replace all occurences of

        var offerinputform = this.shadowRoot.getElementById('offerinputform');

with

        var offerinputform = this.$.offerinputform;