swarmcity / sc-boardwalk

NO LONGER ACTIVE, current development of dApp in SwarmCitySite
25 stars 13 forks source link

#238 cancel deal #401

Closed rodney757 closed 7 years ago

rodney757 commented 7 years ago

This is dependent on https://github.com/swarmcity/sc-dappcontracts/tree/with-events.

rodney757 commented 7 years ago

also, most of the commits are just from the merge of master

rodney757 commented 7 years ago

the sc-chainlisteners element is not initialized anywhere, as I wasn't sure if we wanted to only fetch old deals on an archive page or on the hashtag.

Another issue is that sc-listeners will clear the deals when the listener is changed. I didn't change that for the same reasons as not initializing the sc-chainlisteners element.

To test, just comment out the clear deals action in sc-listeners and initialize the sc-chainlisteners element somewhere

sponnet commented 7 years ago

All these issues are integrated in Pr #401