search

swarmcity / terminal-ts

Terminal implementation in TS
0 stars 0 forks source link

chore: refactor login / create-account pages #19

Closed filoozom closed 2 years ago

filoozom commented 2 years ago

In this PR I put every component in its own file and removed all the routing inside the CreateAccount page, so that it stays coherent.

The disadvantage is that all the progress is lost on refresh. This also goes for pressing the "back" button, as it would go from any state in CreateAccount to the Login page. This is probably not desirable, so I guess routing might be more appropriate?

github-actions[bot] commented 2 years ago

🐝 PR preview in Swarm

Preview URL: https://bah5acgzamghdh4etemd4sksryiyxbm3k2ed4uvv7ikdcimaukpnbfd5smarq.bzz.link Swarm Hash: 618e33f0932307c92a51c23170b36ad107ca56bf428624301453da128fb26023 Commit Hash: 801db5ba3428e60f1e5d1ebe67033ab98b572645 Commit Message: chore: refactor login / create-account pages

lucille-bellepleure commented 2 years ago

I don't think it's useful to keep the progress of this "form". What I did like though was the idea to launch the app with an account already there. The user could "claim" and personalise the account or restore (import) an existing one.

vojtechsimetka commented 2 years ago

I don't think it's useful to keep the progress of this "form". What I did like though was the idea to launch the app with an account already there. The user could "claim" and personalise the account or restore (import) an existing one.

What do you mean? Not quite sure I understand this comment.

vojtechsimetka commented 2 years ago

@filoozom can we get this merged? Would love to base my changes on top of this :)