search

swarmpit / agent

Swarmpit docker agent
16 stars 13 forks source link

Monitor all disk usage not only root #5

Open bpoussin opened 4 years ago

bpoussin commented 4 years ago

Only root partition usage is monitoring, this is not useful when data are mounted on another partition. Quick modification, can be to use env variable to know partition to monitor and default if not present is root partition. Better way is to monitor all data partitions (not /sys, /proc, ...), but some modification must be done in front end to display that.

Do you think the quick modification is acceptable ?

nohaapav commented 4 years ago

I suggest to keep root partition as it is to keep api backward compatible and add new attribute such mountedDisks which is going to be configured via env variables .. Then we can do FE modification to display that.