search

swaroopch / edn_format

EDN reader and writer implementation in Python, using PLY (lex, yacc)
https://swaroopch.com/2012/12/24/edn-format-python/
Other
133 stars 31 forks source link

Update edn_dump.py to accept datetime.date #22

Closed olivergeorge closed 10 years ago

olivergeorge commented 10 years ago

As per #18 it seems fine to pass an ISO format date as #inst

swaroopch commented 10 years ago

Hi @olivergeorge, thanks for this effort, if you don't mind, can you also please include a test for this? Thanks!

swaroopch commented 10 years ago

I've added code to recognize the date-format #inst and added tests for the same.

olivergeorge commented 10 years ago

Awesome.

In case you're curious I used your library to make django-rest-framework provide a (read-only) edn api. I haven't used it in anger yet but it seems to work like a treat.

swaroopch commented 10 years ago

@olivergeorge That's neat! I just made a new release with this fix, so please do use the new version on PyPI.

Also, do let me know if you ever push this to production, so that I can update the README that there are indeed folks using this in production :)

olivergeorge commented 10 years ago

Will do.

On 3 May 2014 11:31, Swaroop C H notifications@github.com wrote:

@olivergeorge https://github.com/olivergeorge That's neat! I just made a new release with this fix, so please do use the new version on PyPI.

Also, do let me know if you ever push this to production, so that I can update the README that there are indeed folks using this in production :)

— Reply to this email directly or view it on GitHubhttps://github.com/swaroopch/edn_format/pull/22#issuecomment-42092938 .