search

swaroopch / edn_format

EDN reader and writer implementation in Python, using PLY (lex, yacc)
https://www.swaroopch.com/Wrote-an-EDN-format-reader-and-writer-in-Python-11e0924249b181e3af8bdb9af1456373
Other
134 stars 31 forks source link

Handle fractions #23

Closed swaroopch closed 9 years ago

swaroopch commented 10 years ago

https://github.com/edn-format/edn/issues/64

@marianoguerra @bitemyapp @jashugan Can you please review this change to handle fractions? Thanks!

bfontaine commented 6 years ago

Why was this not merged?

bfontaine commented 6 years ago

I believe this is the last feature we need to support in order to be fully EDN-compliant.

I’ve used code from clojure.edn’s test suit to generate 500k valid EDN strings, which I then passed to edn_format.loads. There were 19k errors, all due to edn_format not handling fractions.

swaroopch commented 6 years ago

@bfontaine Unfortunately, I don't recall why I closed this PR (should've written the reason!), my guess is tests weren't passing or something like that. Do you mind taking over this PR?

swaroopch commented 6 years ago

Never mind, just saw https://github.com/swaroopch/edn_format/pull/49 :)