search

swaroopg92 / penpa-edit

Web application to create and solve Sudokus and Puzzles
https://swaroopg92.github.io/penpa-edit/
Other
110 stars 42 forks source link

Code cleanup #133

Closed davmillar closed 1 year ago

swaroopg92 commented 1 year ago

@davmillar I was testing this. I found one issue, in Sudoku Mode (If you have Numpad Keyboard). (No issues with Numbers above the Qwerty) Original Behavior it was/it should be: Shift + Numbers in Numpad = place the digit in the corners of the cell. Current Changed Behavior: SHIFT + 4/6/8/2, it also moves a cell and then places the number in the corner. (The arrow key got activated)

I presume because of the rearrangement of the code, one of the condition checks got misplaced. I am traveling for a week and won't have access to my development laptop. If you find time, take a look or I will debug once I am back End of July.

davmillar commented 1 year ago

I can't seem to get the digit entry working on my laptop -- in this branch or in main! Can you please verify that it works for you now? I'll debug the digit part further tomorrow -- too tired right now.

swaroopg92 commented 1 year ago

I will watch out if anyone reports anything, but it worked on my end, merged, and pushed. Thanks.