swaroopg92 / penpa-edit

Web application to create and solve Sudokus and Puzzles
https://swaroopg92.github.io/penpa-edit/
Other
104 stars 42 forks source link

Convert popups to use helper functions and branding file to make rebr… #138

Closed davmillar closed 1 year ago

davmillar commented 1 year ago

…anding the app easier.

Note to Swaroop: -- this will likely cause some pain on the GMP branch to initially undo some of the changes specific to GMP, but you should be able to just update Branding.js for that branch and it will be a single point to edit in the future. I will look at the LMI and GMP branches more in the next week or two and see what else can be done to make it easier to have a single main repo and a single file that people can customize to make special editions. I know there are more functional changes specific to them as well but this should help a little bit. :)

swaroopg92 commented 1 year ago

@davmillar I have merged it for the Main Penpa. I will see about merging it with gmp/lmi later in a couple of weeks. Thanks for your continuous efforts and contributions.