search

swarooppatilx / scruter

Scruter is a local classifieds and community site designed to bring people together for buying, selling, and exchanging goods and services.
https://scruter.vercel.app
GNU General Public License v3.0
23 stars 94 forks source link

REFACTORING #135

Open swarooppatilx opened 1 week ago

swarooppatilx commented 1 week ago

This is a serious issue, I noticed many PRs are applying custom css which is inconsistent with the website theme. I think its time we decide to have a global css with styles that are applied to whole website.

Not just css, the whole structure needs to be redesigned with DRY principles and modular approach in mind.

app.js file does more things than it needs to. we have to seperate the routes, database logic from app.js

I will be accepting PRs of refactoring code with level 1 or level 2 depending on the complexity.

Be sure not to break existing code, test it throughly.

sayiamarora commented 1 week ago

Hey @swarooppatilx ........ Can you provide with me more details and requirements for this issue.

swarooppatilx commented 1 week ago

@sayiamarora you can do any of the above mentioned tasks like seperating routing and database logic from app.js

or creating global styles and apply the same instead of putting everything inside head.ejs

rishabh7923 commented 6 days ago

I’m confident that I can add a professional touch to code, organizing everything in a clear and intuitive way so that other developers can easily navigate and work with it.

To be precise, I want to work on this first.

app.js file does more things than it needs to. we have to seperate the routes, database logic from app.js

sayiamarora commented 4 days ago

Hey @swarooppatilx Check my PR #181. I have Refactored it completely and make the App.js file look cleaner and more readable.