swarooppatilx / scruter

Scruter is a local classifieds and community site designed to bring people together for buying, selling, and exchanging goods and services.
https://scruter.vercel.app
GNU General Public License v3.0
28 stars 135 forks source link

[Migration] Add about us & Our team pages to NextJS #349

Closed mehul-m-prajapati closed 2 weeks ago

mehul-m-prajapati commented 3 weeks ago

Description

Screenshots

p1

Checklist

github-actions[bot] commented 3 weeks ago

👋 Thank you @mehul-m-prajapati for raising an issue! We appreciate your effort in helping us improve. Our team will review it shortly. Stay tuned! If you need further assistance or want to join the conversation, feel free to join our Discord server: Discord Link

ShivanshPlays commented 2 weeks ago

@mehul-m-prajapati the pages that u have added, have u added layout in each of the routes (folder) , as there was already a layout at the root level, I have to add protected routes of the seller and I am struggling due to the redundant layouts

ShivanshPlays commented 2 weeks ago

image all the user side pages will go into (routes) and then there is API and at this level i want to add seller routes, can u please do the necessary restructuring and push it

mehul-m-prajapati commented 2 weeks ago

@ShivanshPlays : The layout files are generated by nextjs. I have just added page files

ShivanshPlays commented 2 weeks ago

yes i understood that but it will voilate seperation of concerns of user specific things and seller specific things, can we please agree on a proper structure for the project, as adding files anywhere and everywhere will make the project cluttered.

My suggestion:

app will have

  1. (routes) will have all public pages....
  2. (api) and
  3. (seller) which will have all protected routes and then there will be all their respective files
mehul-m-prajapati commented 2 weeks ago

I have added footer files and not any of the user-specific pages for now.

1
mehul-m-prajapati commented 2 weeks ago
ShivanshPlays commented 2 weeks ago

Thanks for understanding I hope u understand that i am not questioning your work and just discussing for the modularity of code in the project, a humble request: please shift and push with the pages you added in the (routes) folder as they are not user specific but should be in routes as they come under the category of public pages

mehul-m-prajapati commented 2 weeks ago

okay, thanks for your input. I have opened the issue https://github.com/swarooppatilx/scruter/issues/415 regarding the same and will move those pages in routes dir.

ShivanshPlays commented 2 weeks ago

sure, I appreciate it , thanks for understanding @mehul-m-prajapati