[Feat] completely fix the TOS page, check description #431

swarooppatilx / scruter

Scruter is a local classifieds and community site designed to bring people together for buying, selling, and exchanging goods and services.

https://scruter.vercel.app

GNU General Public License v3.0

28 stars 135 forks source link

[Feat] completely fix the TOS page, check description #431 #480

Closed AE-Hertz closed 1 week ago

AE-Hertz commented 2 weeks ago

What does this PR do?

[Feat] completely fix the TOS page, check description #431

Fixes #431

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

[X] Test A
[X] Test B

Mandatory Tasks

[X] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Screenshot 2024-11-06 115658

vercel[bot] commented 2 weeks ago

@AE-Hertz is attempting to deploy a commit to the Piyush's projects Team on Vercel.

A member of the Team first needs to authorize it.

AE-Hertz commented 2 weeks ago

@swarooppatilx i have implemented following this:

improved the ui of tos page
as migrating to nextjs, i implemented this in next
dynamic year section changer
pre-implemented dark mode

If you like, can you consider upgrading level. thank you.

swarooppatilx commented 2 weeks ago

looks good, I'll need to ask some ppl about the new UI and I'll let you know if we need to apply it other pages as well

AE-Hertz commented 2 weeks ago

can you optimize this for mobile? scrolling on mobile is difficult due to scroll view, and UI isnt responsive on mobile

if its fine with you can i raise another issue for it and work right away, instead of doing it here. @swarooppatilx

swarooppatilx commented 2 weeks ago

can you optimize this for mobile? scrolling on mobile is difficult due to scroll view, and UI isnt responsive on mobile

if its fine with you can i raise another issue for it and work right away, instead of doing it here. @swarooppatilx

no its part of the redesign, I'll raise the level, just make sure it aligns with the website theme (nextjs)

AE-Hertz commented 2 weeks ago

can you optimize this for mobile? scrolling on mobile is difficult due to scroll view, and UI isnt responsive on mobile

if its fine with you can i raise another issue for it and work right away, instead of doing it here. @swarooppatilx

no its part of the redesign, I'll raise the level, just make sure it aligns with the website theme (nextjs)

sure, no problem, i will make this website responsive for mobile breakpoints..

AE-Hertz commented 2 weeks ago

https://github.com/user-attachments/assets/113c1bb6-ac05-431a-9328-9e6e956c6314

@swarooppatilx things implemented: